Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSNR camera coadd fix #1197

Merged
merged 2 commits into from Mar 23, 2021
Merged

TSNR camera coadd fix #1197

merged 2 commits into from Mar 23, 2021

Conversation

michaelJwilson
Copy link
Contributor

Addresses #1193. Runs through the use case example provided there and passes other vetting on values.

For future consideration: rename TSNR_QSO to TSNR_QSO_BRZ etc. to mirror nomenclature for flux etc.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 28.902% when pulling 20fd290 on tsnr-camera-coadd-fix into f3895a1 on master.

@sbailey
Copy link
Contributor

sbailey commented Mar 23, 2021

Thanks for the fix, looks good. I'm open to discussing TSNR2_XYZ vs. TSNR2_XYZ_BRZ but let's merge this bugfix now without changing the datamodel, and independently decide if we want to change the column name (and let's decide that before running Denali, i.e. soon).

@sbailey sbailey merged commit 793f32f into master Mar 23, 2021
@sbailey sbailey deleted the tsnr-camera-coadd-fix branch March 23, 2021 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants