loose 100 um quality cut on fiber positioning #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts in a loose 100 micron quality cut on fiber positioning. For tonight I didn't put in a tighter cut because the impact of
FIBERSTATUS != 0is pretty draconian, resulting in ivar=0 for all wavelengths and a guaranteed loss of redshift, limiting our ability to study borderline cases with a tighter cut. Better would be a warning flag that doesn't automatically force the target to junk, but that takes more surgery. I also explored catching this post-facto with cuts on the redrock side, but got bogged down with what to do if one exposure was good but another was borderline and another was bad...Kevin has also identified some bit misinterpretation where we are flagging some good positioners as bad, but I need to talk to him more to determine the correct recipe, so this FIBERSTATUS algorithm will almost certainly change again soon. So much for spectro pipeline stability during the 1% survey...