Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GFA-like TSNR template for dark, bright and backup programs #1279

Merged
merged 3 commits into from May 26, 2021

Conversation

michaelJwilson
Copy link
Contributor

Add gfa-like templates to compute gfadark, gfabright and gfabackup tsnrs (same signal, differ by poisson term to IVAR, and soon fiberfrac).

desi_compute_tsnr_ensemble --tracer gfa --outdir .

Creates:
./tsnr-ensemble-gfadark.fits

image

cp and (SVN) symlink at desimodel/data/tsnr/ to
tsnr-ensemble-gfabright.fits
tsnr-ensemble-gfabackup.fits

Runs through afterburner:

export SPECPROD=daily
export DESI_SPECTRO_CALIB=/global/cfs/cdirs/desi/spectro/desi_spectro_calib/trunk/
export DESIMODEL=/global/cscratch1/sd/mjwilson/GFATEMPLATE/desimodel/

desi_tsnr_afterburner --outfile /global/cscratch1/sd/mjwilson/tsnr-ensemble-updates/tsnr-summary.fits --expids 88359,88360,89881 --recompute --nproc 12 --cameras b0

TSNR2_GFADARK_B = 64.087897
TSNR2_GFABRIGHT_B = 60.688630
TSNR2_GFABACKUP_B = 49.803252

@coveralls
Copy link

coveralls commented May 25, 2021

Coverage Status

Coverage decreased (-0.04%) to 27.479% when pulling d705ec4 on tsnr-gfatemplates into d73f092 on tsnr-ensemble-updates.

Copy link
Contributor

@julienguy julienguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. No comment on the code.
Only one change request: replace the 'tracer' name 'GFA' by something different to avoid confusion with the EFFTIME derived from the actual GFA measurements from Aaron.
A suggestion is 'RBAND' (it cannot be 'R' only because of the confusion with the spectrograph camera arm label). Other ideas welcome.

@michaelJwilson
Copy link
Contributor Author

michaelJwilson commented May 26, 2021

Excellent. I'm going to suggest, which I'll implement unless there's pushback, is GPB for Guider Pass Band.

I'm also going to set it up to generate three separate templates GPBDARK, GPBBRIGHT, GPBBackup. These will be the same except for the tracer label in the header.

The symlinks don't really work as some downstream code (not much, but e.g. titles to calibrate_template plots), relies on this tracer keyword.

@julienguy julienguy marked this pull request as ready for review May 26, 2021 20:45
@julienguy julienguy self-requested a review May 26, 2021 20:46
@julienguy julienguy merged commit 383dc3f into tsnr-ensemble-updates May 26, 2021
@julienguy julienguy deleted the tsnr-gfatemplates branch May 26, 2021 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants