Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DESI average throughput from SV1 and SV3 #1291

Merged
merged 11 commits into from Jun 3, 2021
Merged

DESI average throughput from SV1 and SV3 #1291

merged 11 commits into from Jun 3, 2021

Conversation

julienguy
Copy link
Contributor

Use the new measurement of the throughput presented in https://desi.lbl.gov/DocDB/cgi-bin/private/ShowDocument?docid=6157 .

  • define new attributes to the class desispec.averagefluxcalibration.AverageFluxCalib (median_seeing, median_ffracflux, fac_wave_power, ffracflux_wave,first_night)
  • use this when computing the sky magnitudes
    (a new version of the average flux calibration following this new data model is saved in the spectro calibration svn repo, see https://desi.lbl.gov/trac/browser/calib/desi_spectro_calib/trunk/spec/fluxcalib)

@coveralls
Copy link

coveralls commented Jun 2, 2021

Coverage Status

Coverage decreased (-0.02%) to 27.603% when pulling f670268 on throughput-sv13 into 040a4d5 on master.

@julienguy
Copy link
Contributor Author

merging this PR that affects only the sky magnitude after the improved measurement of the throughput (3% change in calibrated sky flux).

@julienguy julienguy merged commit 4e37b17 into master Jun 3, 2021
@julienguy julienguy deleted the throughput-sv13 branch June 12, 2021 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants