Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desi_tile_redshifts --run_zqso option #1293

Merged
merged 2 commits into from Jun 6, 2021
Merged

desi_tile_redshifts --run_zqso option #1293

merged 2 commits into from Jun 6, 2021

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Jun 4, 2021

This PR

  1. adds a desi_tile_redshifts --run_zqso option to run make_zqso_files after running redshifts
  2. pipeline automatically includes --run_zqso for cumulative redshifts but not other groupings
  3. adds copyprod --night YEARMMDD option, which can include a wildcard, like copyprod --night 202106\* ... (unreleated to --run_zqso, but used for testing).

I have tested (1) and (3), but not (2).

Outputs of desi_tile_redshifts -n 20210601 -t 1207 -g cumulative --run_zqso are in /global/cfs/cdirs/desi/users/sjbailey/spectro/redux/zqso/tiles/cumulative/1207/20210601

@akremin please check pipeline logic; @geordie666 and/or @eleanorlyke please check zqso outputs.

@sbailey sbailey requested a review from akremin June 4, 2021 23:50
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 27.321% when pulling da5a417 on zqso into 84e46e8 on master.

@akremin
Copy link
Member

akremin commented Jun 5, 2021

From the pipeline perspective: the logic looks good.
It's so minor that I'm not terribly worried about testing it, but I will run a test anyway and report back.

Copy link
Member

@akremin akremin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with desi_daily_proc_manager --override-night=20210601 --dry-run-level=1 in a test SPECPROD to verify that it works.

The cumulative redshift scripts produced by the pipeline had the new zqso code.

It worked as expected.

@geordie666
Copy link
Contributor

The zqso outputs look good. I did a mini-run and achieved the same results. The necessary columns are all there, the files all have the expected 500 rows.

As a final check, for objects with IS_QSO_QN==1 and ZWARN==0 the redshift agreement between redrock and QN is excellent. So, this all checks out.

@sbailey sbailey merged commit 7c7c6d5 into master Jun 6, 2021
@sbailey sbailey deleted the zqso branch June 6, 2021 00:02
@sbailey sbailey added this to In progress in Everest via automation Jun 7, 2021
@sbailey sbailey moved this from In progress to Done in Everest Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Everest
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants