Minor fix in sky subtraction when fiber has ivar=0 #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e same frame with a correction coefficient; this was a source of a bug when all fiber has ivar=0
|
tested on previously bad cframes, looks good. |
sbailey
reviewed
Mar 17, 2020
| @@ -1160,7 +1159,6 @@ def subtract_sky(frame, skymodel, throughput_correction = False, default_through | |||
|
|
|||
| if mcoeferr>np.abs(mcoef-1) : | |||
| log.warning("throughput corr error = %5.4f is too large compared to the correction value = %5.4f for fiber #%03d, do not apply correction"%(mcoeferr,(mcoef-1),fiber)) | |||
| throughput_correction_value = default_throughput_correction | |||
There was a problem hiding this comment.
turns out this was needed, because otherwise throughput_correction_value isn't set in this case and the code crashes a few lines later when it is used. I updated directly to master to set this to 1.0. We can chase separately what causes this warning special case and whether we should do something different about it, but for the moment I was looking for the minimal fix to get back and running.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use copy of frame instead of applying twice the sky subtraction on the same frame with a correction coefficient; this was a source of a bug when all fiber has ivar=0.