Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force assemble_fibermap for nights before or during 20200310 #936

Merged
merged 1 commit into from Mar 27, 2020

Conversation

akremin
Copy link
Member

@akremin akremin commented Mar 27, 2020

" --force" is an optional keyword to assemble_fibermap meant to be run if the code fails because of a missing coordinates file. We want the code to fail by default to indicate that ICS didn't provide coordinate information. However, early commissioning data sometimes didn't include this and for reprocessing of minisv2 and sv0 it is a known issue we would like to look past.

For future data we still want to know when coord* files aren't supplied, so the code still fails by default in those instances.

@akremin akremin requested a review from sbailey March 27, 2020 21:03
bin/desi_proc Show resolved Hide resolved
@akremin
Copy link
Member Author

akremin commented Mar 27, 2020

Tested with:
desi_proc --batch -n 20200219 -e 51059
(where there is no coordinates file)

and:
desi_proc --batch -n 20200219 -e 51060
(where this is a coordinates file).

Works in both instances

@akremin akremin merged commit 3022f1c into master Mar 27, 2020
@akremin akremin deleted the force_assemble_fibmap branch March 27, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants