Do not fit trace shifts along wavelength for dome or twilight flats #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a change of options for desi_proc when calling
desi_compute_trace_shifts.The code was trying to re-adjust the wavelength solution from fiber to fiber by cross-correlating fast-extracted spectra on dome flats and twilight flats. This works fine for standard science exposures but leads to large wavelength errors for the flats. In this PR this feature is simply disabled.
"Flat-fielded" twilight sky data now look better but still show a significant EW gradient.
"Flat-field" dark sky data are noisier but provide an interesting data QA which highlight the problematic cameras.