propagate MJD to spectra fibermap #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akremin
reviewed
Apr 3, 2020
py/desispec/pixgroup.py
Outdated
| @@ -181,9 +181,11 @@ def read(cls, filename): | |||
| nspec = len(fibermap) | |||
| night = np.tile(header['NIGHT'], nspec).astype('i4') | |||
| expid = np.tile(header['EXPID'], nspec).astype('i4') | |||
| mjd = np.tile(header['MJD-OBS'], nspec).astype('f8') | |||
There was a problem hiding this comment.
MJD-OBS is a pretty fundamental keyword that should be in every exposure, but are we confident enough of this card's existence that we want the code to fail if it isn't there?
There was a problem hiding this comment.
Good point. I updated code to support "MJD-OBS" (current data), "MJD" (older sims), and not crash if both are missing (still propagates an MJD=-1 column to keep the data model consistent).
akremin
reviewed
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #852 by propagating the MJD-OBS header keyword to a MJD column in the output fibermap of spectra files (similar to propagating NIGHT, EXPID, and TILEID).
Tested with:
and verifying that the output file has an MJD column filled into the FIBERMAP table.