Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts for creating pixmasks #946

Merged
merged 10 commits into from Apr 15, 2020
Merged

Scripts for creating pixmasks #946

merged 10 commits into from Apr 15, 2020

Conversation

biprateep
Copy link
Contributor

The following changes were made:

  • The name of one of the ccd mask bit has been changed (saturated->highvar)
  • A script to generate pix masks from darks had been added to /bin
    @julienguy

@julienguy
Copy link
Contributor

Thanks for this. Two requests of changes:

  • add a new bit HIGHVAR instead of replacing the SATURATED one. we still need it.
  • add default values for all the input parameter arguments of the script desi_compute_mask_dark

@biprateep biprateep closed this Apr 6, 2020
@biprateep biprateep reopened this Apr 6, 2020
@biprateep
Copy link
Contributor Author

biprateep commented Apr 6, 2020

I have made the requested changes. One thing to note is that the default values are very indicative and need to be tuned on a per ccd basis. The real masks were generated using tuned values. I'll probably store these exact values on a wikipage. @julienguy

@sbailey
Copy link
Contributor

sbailey commented Apr 7, 2020

@biprateep what was the method used to tune the values on a per CCD basis? Is there supporting code or analysis that could be included here, e.g. to facilitate determining the values to use when a CCD is replaced? Have you generated new pixmasks for all 30 CCDs yet (if so, please point to where they are), or is this laying the groundwork for how you would do that? A wiki page with instructions under https://desi.lbl.gov/trac/wiki/Pipeline/HowTo would be helpful. Thanks.

@biprateep
Copy link
Contributor Author

Hi @julienguy @sbailey @janewman-pitt-edu,
As per the suggestions the following updates have been made:

  • The thresholds are set in terms of percentiles rather than absolute values of median and IQT
  • Header info added to the mask files about the parameters
  • incompletely blocked regions are closed
  • columns in an amplifier which has more than a certain fraction of bad pixels (default 0.4) are blocked
  • The scripts takes an optional old mask an input and generates the output as the bitwise OR of the new mask and the old mask

Masks for all the 30 CCDs have been generated and are available here: /global/cscratch1/sd/bid13/desi_masks_dark
the filenames are pixmask-CAMERA.fits. These also masks incorporate the handmade masks.

I have created a page on the wiki how to section and will be updating a detailed documentation about the algorithms and thresholds.

@julienguy julienguy merged commit 9419da0 into desihub:master Apr 15, 2020
@sbailey sbailey mentioned this pull request Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants