Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for python 3.8 #990

Merged
merged 5 commits into from Jul 24, 2020
Merged

support for python 3.8 #990

merged 5 commits into from Jul 24, 2020

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Jul 23, 2020

This PR fixes several items found while testing with python 3.8:

  • a QA bug about changing dict keys while iterating over the dict keys
  • use collections.abc.Callable instead of collections.Callable
    • deprecated for a long time; will break in py3.9 (but now fixed here)
    • FYI, "abc" = "Abstract Base Classes", not just a random submodule name
  • Don't complain about nanomaggies as an invalid FITS unit
  • in the test code, I left behind some commented hooks for how to treat a specific
    warning as an error just for those tests, useful for tracking down where the warning
    is coming from so you can know where to go to fix it.

@sbailey sbailey merged commit 7053c0c into master Jul 24, 2020
@sbailey sbailey deleted the py3.8 branch July 24, 2020 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant