Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving freeze_iers to desiutil #106

Closed
weaverba137 opened this issue Dec 23, 2019 · 3 comments · Fixed by desihub/desiutil#139
Closed

Consider moving freeze_iers to desiutil #106

weaverba137 opened this issue Dec 23, 2019 · 3 comments · Fixed by desihub/desiutil#139

Comments

@weaverba137
Copy link
Member

freeze_iers() currently has two purposes:

  1. The normal purpose of preventing code on a compute node from being forced to download the IERS-A table.
  2. The extra, workaround purpose of preventing all code from downloading the IERS-A table from a server that is unavailable.

This creates a dependency on desisurvey for code that would not normally ever need that dependency. If freeze_iers() were moved to desiutil, this extra dependency would be unnecessary.

@dkirkby
Copy link
Member

dkirkby commented Dec 23, 2019

There is a third purpose, which was the original motivation and the reason it currently lives in desisurvey: ensure exactly reproducible coordinate transformations over the survey duration for the purpose of scheduling tiles in forecasts and operations.

@weaverba137
Copy link
Member Author

Good point, but that would not prevent us from moving the code to desiutil.

@weaverba137
Copy link
Member Author

In addition: from recent tests on desisim, it looks like freeze_iers() is not compatible with astropy 4.0. Make sure to test this if/when this moves to desiutil.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants