Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate TARGETID in skysupp #647

Closed
forero opened this issue Nov 10, 2020 · 3 comments
Closed

Duplicate TARGETID in skysupp #647

forero opened this issue Nov 10, 2020 · 3 comments
Assignees
Labels

Comments

@forero
Copy link
Member

forero commented Nov 10, 2020

Using /global/cfs/projectdirs/desi/target/catalogs/gaiadr2/0.43.0/skies-supp/ I found the duplicate TARGETID 2882304691935379461. That duplicate TARGETID made fba_run crash on cmx tests I was running for TILEID 5009.

@forero forero added the bug label Nov 10, 2020
@sbailey sbailey added this to To do in SV-start via automation Nov 10, 2020
@forero
Copy link
Member Author

forero commented Nov 12, 2020

Anand in an email:

so I gave a check, I find that:

  • there are no duplicates in skies-hp-*.fits
  • there are no duplicates between skies-hp-.fits and skies-supp-hp-.fits
    perfect.

but there are some duplicates inside the skies-supp-hp-*.fits:

  • skies-supp-hp-0.fits has 1291 duplicates
  • there are some duplicates between the skies-supp-hp-*.fits files (if I
    got it right, overall, 4594 out of 354,064,078, with counting the 1291
    duplicates from skies-supp-hp-0.fits)

to my understanding, that shouldn t happen, right? or is it expected?

thanks!

anand

ps: I m checking:
/global/cfs/projectdirs/desi/target/catalogs/dr8/0.43.0/skies/skies-hp-.fits
/global/cfs/projectdirs/desi/target/catalogs/gaiadr2/0.43.0/skies-supp/skies-supp-hp-
.fits

@geordie666
Copy link
Contributor

Thanks for the digging @forero (via Anand!). That's definitely a bug. I'll try to look at it later today.

@geordie666
Copy link
Contributor

Addressed in #653.

@geordie666 geordie666 moved this from In progress to Done in Restart2020 Nov 23, 2020
SV-start automation moved this from To do to Done Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Restart2020
  
Done
SV-start
  
Done
Development

No branches or pull requests

2 participants