Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate copying checked out code to final install directory #97

Closed
weaverba137 opened this issue Jan 22, 2018 · 3 comments
Closed

Eliminate copying checked out code to final install directory #97

weaverba137 opened this issue Jan 22, 2018 · 3 comments
Assignees

Comments

@weaverba137
Copy link
Member

Historically as part of the desiInstall script, we copied the contents of the working/build directory to the final install directory, in addition to actually installing the code (python setup.py install / make install) in the same directory.

This isn't really necessary anymore, since we've moved necessary package data inside the Python packages themselves, so data gets installed along with the Python package. However, a few packages, particularly desimodel, still need extra data that is downloaded to the build directory, then copied into place.

This issue will track any additional packages that need special data install handling, and the eventual removal of the code. Other issues will track the modification of the data scripts to install directly to the install directory.

@weaverba137
Copy link
Member Author

I looked through every package on https://github.com/desihub, and only desimodel has the script that is automatically invoked by desiInstall.

@weaverba137
Copy link
Member Author

The other reason this capability exists is to support trunk/master/branch installs. Maybe those should be done by hand from now on, especially if we don't change desiconda versions very often.

@weaverba137
Copy link
Member Author

Oops, didn't mean to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant