Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tied [OII]7320/[OII]7330 flux ratio inverted #119

Closed
dirkscholte opened this issue Apr 18, 2023 · 1 comment
Closed

Tied [OII]7320/[OII]7330 flux ratio inverted #119

dirkscholte opened this issue Apr 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@dirkscholte
Copy link
Member

The [OII]7320,7330 lines are tied such that amp([OII]7320) = 1.0 / 1.2251 * amp([OII]7330). This should be the other way around: amp([OII]7320) = 1.2251 * amp([OII]7330). This was correctly implemented PR #87 associated with issue #84 . However, likely during the refactoring of the emission line fitting this tied emission line ratio got switched around.

Small changes to be made in emlines.py and nebular-lines.ipynb to correct the inverted emission line ratio.

image
@dirkscholte dirkscholte added the bug Something isn't working label Apr 18, 2023
@dirkscholte dirkscholte mentioned this issue Apr 18, 2023
Merged
@moustakas
Copy link
Member

Fixed in #120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
EDR FastSpecfit VAC
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@moustakas @dirkscholte