Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prospect_demo.ipynb is not actually a notebook #37

Closed
weaverba137 opened this issue Apr 23, 2020 · 3 comments
Closed

Prospect_demo.ipynb is not actually a notebook #37

weaverba137 opened this issue Apr 23, 2020 · 3 comments
Assignees
@armengau
Labels
bug Something isn't working

Comments

@weaverba137
Copy link
Member

Prospect_demo.ipynb is actually an HTML file, not a notebook. If you want to check in HTML, please check in both HTML and the actual notebook.
@weaverba137 weaverba137 added the bug Something isn't working label Apr 23, 2020
@weaverba137
Copy link
Member Author

In fact, it's even worse than that, because the HTML is a copy of a GitHub page that shows the HTML failing to load. As far as I can tell this is a total loss. This may require deep searching through the git commit history to find a valid version.

@weaverba137 weaverba137 mentioned this issue Dec 11, 2020
Merged
@armengau
Copy link
Collaborator

Prospect_demo.ipynb is now a notebook again, compatible in principle with prospect branch pip-installable-package.
I should still update the demo code in this old notebook.

@armengau
Copy link
Collaborator

Notebook updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@armengau armengau

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@weaverba137 @armengau