-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error while running redrock in mock spectra #205
Comments
Thanks for the crash report @LuzGarciaP. I'm looking at this issue in the scores-optional branch but I'm running into a related issue in that your mock spectra don't contain resolution information either, which is much more "baked" into I made a small change to make it further along into redrock without the resolution information but I am now crashing during the redshift scanning. E.g., with my branch
I suspect that for DESI-style input spectra (via the use of |
If redrock expects to have the resolution matrix always present we can re-run the mock Luz is using to include it.
|
FWIW, I think rrdesi should not require SCORES or TNSR2 values, but it should require resolution matrix data and the sims should provide that. Since the full resolution matrix format is large and probably overkill for fast sims, a compromise could be to define a Gaussian sigma (or FWHM) vs. wavelength HDU, and update redrock to support converting that into a resolution matrix to use. |
@LuzGarciaP @alxogm, I'm going to close this ticket as resolved, but please feel free to reopen (or open a new one) if this is still an issue. |
When trying to run redrock on a small set of mocks located here: /global/cscratch1/sd/alxogm/BAL_mocks
I'm getting this error:
Traceback (most recent call last):
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/code/redrock/master/bin/rrdesi", line 9, in
desi.rrdesi(comm=None)
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/code/redrock/master/py/redrock/external/desi.py", line 804, in rrdesi
raise err
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/code/redrock/master/py/redrock/external/desi.py", line 695, in rrdesi
targets = DistTargetsDESI(args.infiles, coadd=(not args.allspec),
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/code/redrock/master/py/redrock/external/desi.py", line 219, in init
scores = encode_table(Table(hdus["SCORES"].data,
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/conda/lib/python3.9/site-packages/astropy/io/fits/hdu/hdulist.py", line 323, in getitem
self._positive_index_of(key))
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/conda/lib/python3.9/site-packages/astropy/io/fits/hdu/hdulist.py", line 780, in _positive_index_of
index = self.index_of(key)
File "/global/common/software/desi/cori/desiconda/20211217-2.0.0/conda/lib/python3.9/site-packages/astropy/io/fits/hdu/hdulist.py", line 761, in index_of
raise KeyError(f'Extension {key!r} not found.')
KeyError: "Extension 'SCORES' not found."
Would it be possible to make SCORES an optional HDU again, please?
Best regards,
Luz García
The text was updated successfully, but these errors were encountered: