-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do the filter curves really have the atmosphere included? #39
Comments
Good catch @moustakas! I just did a quick check against the tabulated source data and you are right that the atmosphere is not included: (shaded = w/o atmos., curve = w/ X=1.3 atmos.) Before I fix this, let me just check that X=1.3 is what you actually want? |
I'm not certain. Let me ask on-list. |
Actually, this issue just affects the SDSS filters, right? So let's just stick with X=1.3. Thanks. |
@moustakas, does this issue need to remain open? |
Done in #76. |
@dkirkby The filters purport to have the atmosphere included
https://speclite.readthedocs.io/en/latest/filters.html
but, e.g., the SDSS i-band filter appears to be missing the telluric bands around ~7500 A, e.g.
https://www.sdss.org/instruments/camera/#Filters
Any thoughts?
The text was updated successfully, but these errors were encountered: