Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do the filter curves really have the atmosphere included? #39

Closed
moustakas opened this issue Aug 29, 2018 · 5 comments
Closed

do the filter curves really have the atmosphere included? #39

moustakas opened this issue Aug 29, 2018 · 5 comments

Comments

@moustakas
Copy link
Member

@dkirkby The filters purport to have the atmosphere included
https://speclite.readthedocs.io/en/latest/filters.html
but, e.g., the SDSS i-band filter appears to be missing the telluric bands around ~7500 A, e.g.
https://www.sdss.org/instruments/camera/#Filters

Any thoughts?

@dkirkby
Copy link
Member

dkirkby commented Aug 30, 2018

Good catch @moustakas! I just did a quick check against the tabulated source data and you are right that the atmosphere is not included:
sdss

(shaded = w/o atmos., curve = w/ X=1.3 atmos.)

Before I fix this, let me just check that X=1.3 is what you actually want?

@moustakas
Copy link
Member Author

I'm not certain. Let me ask on-list.

@moustakas
Copy link
Member Author

Actually, this issue just affects the SDSS filters, right? So let's just stick with X=1.3. Thanks.

@weaverba137
Copy link
Member

@moustakas, does this issue need to remain open?

@moustakas
Copy link
Member Author

Done in #76.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants