Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dithering #58

Open
sybenzvi opened this issue Mar 21, 2017 · 6 comments
Open

Add support for dithering #58

sybenzvi opened this issue Mar 21, 2017 · 6 comments
Assignees

Comments

@sybenzvi
Copy link

This is a feature request moved from desimodel. Specsim should allow the user to dither the telescope given an observation spot in the focal plane. Some hooks are needed in the config and simulator modules. In principle I could implement them, but to avoid conflicts I'll wait for comments from @dkirkby.

@dkirkby
Copy link
Member

dkirkby commented Mar 21, 2017

There is already a configuration parameter we can use for dithering called instrument.offset.value but the logic in specsim.instrument.initialize() will need to be updated so that:

  • either radial or (x,y) offsets can be specified, and
  • a constant offset can be combined with interpolated offsets as a function of (r, lambda) and (x, y).

I don't think any other changes should be necessary (except for docs and unit tests).

@tolgayapici
Copy link

we added a parameter called fiber_placement in the fiberloss module. this change enables the dithering (the scripts are at desidithering) to work. by default, it is set to [0, 0] which makes all the normal operations uninterrupted. the changes are currently on dithering branch. can we merge with master?

@dkirkby
Copy link
Member

dkirkby commented Jul 12, 2017

Please make a pull request so I can review & test your changes.

@tolgayapici
Copy link

before I make a pull request, I realized that travis tests are failing for python2.7
I will try to find the problem first.

@tolgayapici
Copy link

The travis tests fail for transform.py (a file I have not touched) with astropy=development. The last test for the master was done 2 months ago. Is there any change that the astropy[development] has some issues? I have restarted the build of the master and the problem is there too (with transform.py). Do you want me to take a look at transform.py?

@dkirkby
Copy link
Member

dkirkby commented Jul 13, 2017

Thanks for looking into this. I will investigate eventually (and you are welcome to take a look also!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants