Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When discarding a submodule Desktop says it'll end up in Trash but it doesn't #10402

Open
niik opened this issue Aug 18, 2020 · 0 comments
Open
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@niik
Copy link
Member

niik commented Aug 18, 2020

Describe the bug

We tell users that discarded changes can be retrieved from Trash but that's not the case for submodules.

Version & OS

v2.5.4-beta2. Os-independent

Steps to reproduce the behavior

  1. echo "foo" > app/static/choosealicence.com/README.md
  2. Verify that the submodule shows up as a modified entry

image

3. Attempt to discard

image

4. Note how the discard dialog says changes can be retrieved from Trash 5. Discard

Expected behavior

The changed files from the submodule gets moved to Trash

Actual behavior

The submodule changes get reset (after #8218 at least) bypassing the Trash.

Additional context

See #3728 which removed our naive implementation of submodule discarding which caused unexpected results. Let's not repeat that exact blunder but rather find a new and exciting mistake to make.

@niik niik added the bug Confirmed bugs or reports that are very likely to be bugs label Aug 18, 2020
@sergiou87 sergiou87 added this to Triage in Desktop Housekeeping via automation Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
Development

No branches or pull requests

2 participants
@niik and others