Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Difference Swipe mode bugged #11120

Closed
theolaa opened this issue Nov 25, 2020 · 4 comments · Fixed by #11124
Closed

Image Difference Swipe mode bugged #11120

theolaa opened this issue Nov 25, 2020 · 4 comments · Fixed by #11124
Assignees
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@theolaa
Copy link

theolaa commented Nov 25, 2020

Describe the bug

The image difference swipe mode is supposed to let you have a moveable, hard cutoff point on either side of which you can view the differences in an image. The current version locks the left edge of the "old version" of the image to the slider position, rather than the left edge being locked to the left edge of the viewing area (so the images can actually be compared).

Version & OS

Version 2.6.0
Windows 10 Pro

Steps to reproduce the behavior

  1. Find an image in a commit that was changed (not added or deleted).
  2. Select "Swipe" mode from the bottom right
  3. Move the slider (the dot on the blue bar), you will see that the previous version of the image moves around with the slider instead of being locked to the left of the viewing area.

Expected behavior

The image should not move around with the slider, instead, the previous and current versions of the image should occupy the same space in the viewing area, with the slider only hiding and revealing portions of each.

Actual behavior

The current version of the image remains locked in place (as it should), but the previous version of the image moves around with its left edge locked to the slider's position.

Screenshots

image
image
image

Logs

Attach your logs by opening the Help menu and selecting Show Logs..., if applicable.

Additional context

I restarted github desktop and the problem persisted. I assume the error occurs for all supported image formats, but in my particular case it occurs with a .bmp file.

@theolaa theolaa changed the title Image Difference Swipe mod Image Difference Swipe mode bugged Nov 25, 2020
@niik niik added the bug Confirmed bugs or reports that are very likely to be bugs label Nov 25, 2020
@niik
Copy link
Member

niik commented Nov 25, 2020

Hi @theolaa, thanks for opening this! I've opened #11124 which should hopefully address this problem as well as make the swipe mode behave even more like it does on GitHub.com. With a little luck we'll have this fix out in the next production release in a few weeks but if you'd like we'd greatly appreciate it if you'd be willing to try it out in the beta version of the app (we should be shipping an update including this fix within a week). Instructions for installing our beta version are available in our README.

@niik niik self-assigned this Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@niik @theolaa and others