Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No syntax highlighting for HAML #13009

Closed
alexanderadam opened this issue Sep 23, 2021 · 3 comments · Fixed by #13015
Closed

No syntax highlighting for HAML #13009

alexanderadam opened this issue Sep 23, 2021 · 3 comments · Fixed by #13015

Comments

@alexanderadam
Copy link
Contributor

Describe the feature or problem you’d like to solve

There's no syntax highlighting for HAML files in changed files overview.

Proposed solution

People using HAML would be able to have the advantage of helpful syntax highlighting.

@Rpndj

This comment has been minimized.

@niik
Copy link
Member

niik commented Sep 24, 2021

Hi @alexanderadam, thanks for reaching out! It looks like we currently don't have a mapping between the file extension for haml and the syntax highlighting mode. Would you like to contribute support for that mapping? We have some documentation in https://github.com/desktop/desktop/blob/development/docs/technical/syntax-highlighting.md which should let you get started and https://github.com/desktop/desktop/blob/development/app/src/highlighter/index.ts#L43 contains all the currently defined modes which should give you a good idea of what needs to be done to support haml.

@alexanderadam
Copy link
Contributor Author

Hi @niik,

thank you for the fast response! 🙌

Would you like to contribute support for that mapping?

Something like this? I'm not sure I did it right. 🙈
I got the MIME type from CodeMirror documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants
@alexanderadam @niik @Rpndj and others