-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Still unable to discard changes on Windows using WSL #14244
Comments
Thanks for your report @j0nm1! Did this ever work in previous versions of GitHub Desktop? (namely on 2.9.6 and older) |
I just downloaded Version 2.9.6 to try it out. It's exactly the same (but without the confirmation modal), newly created files cannot be discarded. There is no error, the file just doesn't get deleted. Nothing in the logs. |
I was able to reproduce this as well. Discarding changes in a mapped network drive works without issue. |
Same, I'm unable to discard for any files located in WSL (Win11) I have a similar behavior when I try to ignore a file (add to .gitignore) in WSL. Github Desktop v2.9.16-beta1 |
Same behavior here Running windows 11 with wsl2 Github Desktop 2.9.16-beta2 |
Nothing related with github desktop, I just want to said other IDE git also get the same problems with WSL. |
I am also experiencing this issue. GitHub Desktop version 3.2.6 If this helps, using dev tools you can see the following console log from install.ts
So this looks like a git issue instead? ** EDIT ** |
Could this be the reason? |
@ms-afk thanks for sharing that, I'll make a note to look into that this week! |
Search existing issues
The problem
I have cloned a repository on a Windows 11 WSL2 drive (\wsl.localhost\Ubuntu\home...). Then I have created a new file by mistake and I want to discard it. Github Desktop is not able to discard the newly added file (but I can discard changes in files that are already tracked).
When I click the discard changes button, I get the error message that it "Failed to discard changes to Recycle Bin." (which is expected). But after clicking on "Permanently discard changes" it still does not delete the file. After a short loading period, the modal closes itself but the file is still there.
There are no errors in the logs and this is not a permission problem (as I can delete those files manually without any problems)
Release version
2.9.12
Operating system
Windows 11
Steps to reproduce the behavior
Log files
2022-03-28T12:27:12.451Z - info: [ui] [AppStore] loading 5 repositories from store
2022-03-28T12:27:12.453Z - info: [ui] [AppStore] found account: j0nm1 (Jonas Michaelis)
2022-03-28T12:27:12.464Z - info: [ui] [BranchPruner] Last prune took place in 1 hour - skipping
2022-03-28T12:27:12.980Z - info: [ui] launching: 2.9.12 (Windows 10.0.22000)
2022-03-28T12:27:12.982Z - info: [ui] execPath: 'C:\Users\Jonas\AppData\Local\GitHubDesktop\app-2.9.12\GitHubDesktop.exe'
2022-03-28T12:27:12.989Z - info: [ui] Subscribed 'j0nm1' to Alive channel
2022-03-28T12:27:18.240Z - info: [ui] No submodules found. Skipping "git submodule status"
2022-03-28T12:27:19.160Z - info: [ui] No submodules found. Skipping "git submodule status"
Screenshots
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: