Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Desktop: Extremely slow after an update #14950

Open
manas-kulkarni opened this issue Jul 11, 2022 · 38 comments
Open

GitHub Desktop: Extremely slow after an update #14950

manas-kulkarni opened this issue Jul 11, 2022 · 38 comments
Labels
performance Relating to things affecting performance

Comments

@manas-kulkarni
Copy link

manas-kulkarni commented Jul 11, 2022

The problem

Everything has become slow. Clicking on file -> Diff takes 5-6 seconds to load (spinner keeps spinning in diff window)
The same goes for all other actions. Have tried different repos from different servers but the same result.
I have tried to uninstall, and delete the cache from AppData but doesn't help.

Release version

Version 3.0.3 (x64)

Operating system

Windows 10

Steps to reproduce the behavior

  1. Go to the repo
  2. Changelist takes too long to load
  3. Click on any file in the channels to view diff (5-6 seconds to load diff)

Log files

No response

Screenshots

No response

Additional context

No response

@tsvetilian-ty
Copy link
Member

👋 @manas-kulkarni could you upload a log file from GitHub Desktop "Help > Show logs..."?

@tsvetilian-ty tsvetilian-ty added the more-info-needed The submitter needs to provide more information about the issue label Jul 11, 2022
@manas-kulkarni
Copy link
Author

@github-actions github-actions bot removed the more-info-needed The submitter needs to provide more information about the issue label Jul 12, 2022
@sergiou87
Copy link
Member

Hi @manas-kulkarni !

If you updated from 3.0.2 to 3.0.3, I don't think you should experience any changes in performance, at least none of the changes included in 3.0.3 seem like potential reasons for such issue. Have you rebooted your machine since the update? I've seen other users in the past getting performance issues in the app resolved like that 🤞

@sergiou87 sergiou87 added the more-info-needed The submitter needs to provide more information about the issue label Jul 12, 2022
@manas-kulkarni
Copy link
Author

Have restarted multiple times. Can it have something to do with NVIDIA driver update?

@github-actions github-actions bot removed the more-info-needed The submitter needs to provide more information about the issue label Jul 13, 2022
@tidy-dev
Copy link
Contributor

Another thing worth trying is to do a clean install.

  1. Close GitHub Desktop
  2. Remove all of the files in %LOCALAPPDATA%\GitHubDesktop\
  3. Reinstall GitHub Desktop from http://desktop.github.com

Note you will have to add your repositories back and if you have more than one in the same directory, a quick way to do so is to drag and drop the repository folders onto the desktop app.

@manas-kulkarni
Copy link
Author

I have tried that already.

@tidy-dev
Copy link
Contributor

tidy-dev commented Jul 13, 2022

Hmm.. @sakadana mentioned in another similar issue having a gaming pc. Curious if they also had a NVIDIA driver update. We have heard of electron apps (which Desktop is) being impacted by certain graphic cards tho not in this way (was a crash/non start).

@manas-kulkarni
Copy link
Author

I have GTX 1080 Driver 516.59

@tsvetilian-ty
Copy link
Member

tsvetilian-ty commented Jul 13, 2022

I have a device with the same driver, and it works correctly. You could try to add --disable-gpu --disable-software-rasterizer as arguments to GitHub Desktop. This should disable any GPU acceleration.

disable_gpu

@manas-kulkarni could you record your screen while using GitHub Desktop?

@manas-kulkarni
Copy link
Author

manas-kulkarni commented Jul 13, 2022

GitHub.Desktop.2022-07-13.19-28-31.mp4

Check the time it takes to load the repo and then the one line diff. Before it used to be instant

@tsvetilian-ty
Copy link
Member

@manas-kulkarni did you try to disable the GPU?

@manas-kulkarni
Copy link
Author

Yes. Sorry for not mentioning in the last message. It was ran with the args you provided

@sergiou87
Copy link
Member

@manas-kulkarni do you have any kind of Antivirus or real-time scanner that could make everything slower? 🤔

@sergiou87 sergiou87 added the more-info-needed The submitter needs to provide more information about the issue label Jul 14, 2022
@LeahPike
Copy link

LeahPike commented Jul 14, 2022

I've also been experiencing an extreme slowdown recently on GitHub desktop.

An example would be clicking on the changed files in the list, clicking on one to see what has changed takes 5 seconds showing the swirly before it will show the differences. This used be instant.

I should add, I have a NVIDIA GeForce RTX 3080 Ti Laptop GPU.

@Gillardo
Copy link

Same issue, tried adding the GPU disable arguments, still no difference. Have NVIDIA GeForce RTX 3080 as well.

Starting Github desktop takes 5-10 seconds just to load a repo, sync'ing/submitting files again takes 10 seconds +, used to be near instant

@tsvetilian-ty
Copy link
Member

Do you use any antivirus software?
Also, could you check the Task Manager (Ctrl+Shift+Esc) to see if there is an abnormal load on the CPU, Memory, Disk, or GPU?

@manas-kulkarni
Copy link
Author

No anti-virus. CPU load looks normal as well

@github-actions github-actions bot removed the more-info-needed The submitter needs to provide more information about the issue label Jul 14, 2022
@LeahPike
Copy link

LeahPike commented Jul 14, 2022

Do you use any antivirus software?

I'm using WithSecure, but it's mostly disabled as had been causing issues with other programs like steam cloud before.

Also, could you check the Task Manager (Ctrl+Shift+Esc) to see if there is an abnormal load on the CPU, Memory, Disk, or GPU?

If I step between the change files repeatedly this is how task manager looks:

image

When I stop:

image

@sergiou87
Copy link
Member

Thank you @LeahPike , that sounds reasonable. I guess the problem is how long those subprocess take to finish their task.

Is this something new of 3.0.5 or did you notice it too on 3.0.3?

You can also try the latest beta from https://desktop.github.com/beta which includes the latest stable release of Electron (v19) and might make a difference.

@LeahPike
Copy link

Is this something new of 3.0.5 or did you notice it too on 3.0.3?

I've only updated to 3.0.5 today and had noticed the problem for a few days now.

You can also try the latest beta from https://desktop.github.com/beta which includes the latest stable release of Electron (v19) and might make a difference.

This version is actually a lot better, still minor lag compared to what I'm used it. It's taking maybe 500ms between viewing changes instead of 5 seconds. Thanks for this, much more workable :)

@tsvetilian-ty
Copy link
Member

@LeahPike, could you check again with the Task Manager if the beta spawns many processes?

@LeahPike
Copy link

@LeahPike, could you check again with the Task Manager if the beta spawns many processes?

It is no longer spawning so many processes, usually one, occasionally a second when spamming the changed file list.

@AnttiFlashnode
Copy link

I also have this issue, it began after updating from 3.0.3 to either .4 or .5 (didn't use it between the .4 to .5 update). Everything that was near-instantaneous now takes seconds, and this quickly adds up. I've updated nothing else and changed nothing.

@sergiou87
Copy link
Member

Thank you all for your feedback 🙇‍♂️

@AnttiFlashnode the only difference between 3.0.3 and .4/.5 is that we upgraded git from 2.35.3 to 2.35.4, and that only includes a security fix, so I'm surprised about the difference in performance (but it's not impossible!).

If you (or anyone else) is willing to try, this is the link to download v3.0.3 and see if the problems exist in it: https://centralreleases.blob.core.windows.net/github-desktop/releases/3.0.3-ecd0e109/GitHubDesktopSetup-x64.exe

@manas-kulkarni
Copy link
Author

manas-kulkarni commented Jul 15, 2022

Should also add - Slowdown doesnt happen on macOS, only happening on Windows 10

@AnttiFlashnode
Copy link

If you (or anyone else) is willing to try, this is the link to download v3.0.3 and see if the problems exist in it: https://centralreleases.blob.core.windows.net/github-desktop/releases/3.0.3-ecd0e109/GitHubDesktopSetup-x64.exe

Yes, the old version is still as quick as ever! I was wondering if there was a way to downgrade. I guess I'll refrain from updating until someone confirms that a new version doesn't suffer from this.

@Nico-Connor-Personal
Copy link

Nico-Connor-Personal commented Jul 20, 2022

The slowdown is also happening on my machines since the latest update, it's reassuring to hear that the new beta doesn't have the same performance issue for some users.

@sergiou87
Copy link
Member

I wonder if the problem lies on the new Git version somehow. One thing maybe you could try for me:

  1. Install v3.0.3 from https://centralreleases.blob.core.windows.net/github-desktop/releases/3.0.3-ecd0e109/GitHubDesktopSetup-x64.exe
  2. Let it auto-update to v3.0.5
  3. Close GitHub Desktop
  4. Replace the contents of C:\Users\sergiou87\AppData\Local\GitHubDesktop\app-3.0.5\resources\app\git with the contents from C:\Users\sergiou87\AppData\Local\GitHubDesktop\app-3.0.3\resources\app\git
    ⚠️ IMPORTANT ⚠️ : this will replace git 2.35.4 with 2.35.3, which contains a security vulnerability that might affect you. Please, keep a backup of the contents of that folder so you can go back.
  5. Start the app (now it should be 3.0.5) and see if the performance is as good as it was on 3.0.3.

@steveward steveward changed the title GitHubd Desktop: Extremely slow after an update GitHub Desktop: Extremely slow after an update Jul 20, 2022
@manas-kulkarni
Copy link
Author

I have tried multiple git versions going back to 2.34 but same slowdown

@sergiou87
Copy link
Member

@manas-kulkarni thank you, but did you follow the steps I mentioned? GitHub Desktop bundles and uses its own git binaries, and I'd like to know if changing those specifically make a difference in performance 🤔

@manas-kulkarni
Copy link
Author

Yes. I followed your steps and replaced the git inside the GitHub desktop folder. Tried many versions from 2.34.0 to 2.37.2. All had same slowdown

@sergiou87
Copy link
Member

Thank you!! Then I'm terribly puzzled because that is the only change in 3.0.3 vs 3.0.4/5, just those git binaries 🤯

@jkoplo
Copy link

jkoplo commented Aug 2, 2022

Just dropping a note that both a coworker and I experienced this same slowdown on 3.0.5

Switching to the beta cleared everything up.

@steveward steveward added the performance Relating to things affecting performance label Sep 9, 2022
@adamvanaken
Copy link

adamvanaken commented Feb 28, 2023

I have a device with the same driver, and it works correctly. You could try to add --disable-gpu --disable-software-rasterizer as arguments to GitHub Desktop. This should disable any GPU acceleration.

FYI, this worked for me -- not sure what changed, but suddenly today version 3.1.8 started really slowing down on my system, and I found this Issue.

@ghost
Copy link

ghost commented Feb 26, 2024

Anyone got stable solution.....??if yes!! Help me also!!

@matt-richardson
Copy link

matt-richardson commented Mar 7, 2024

EDIT: Gave the machine a reboot, and it's all back to normal speeds. No idea why it suddenly went on a go-slow 🤷

I'm seeing extreme slowness now too, after upgrading to 3.3.11 (arm64) (from 3.3.10 I think).
I'm using an M1 Max mac, running Sonoma 14.3.1.

Looking at the console in the dev tools, it's showing things like:

Executing getAuthorIdentity: git var GIT_AUTHOR_IDENT (took 9.580s)

Running this command with the non bundled git is practically instant.

Interestingly, the bundled git is git version 2.39.3. My local version is git version 2.39.3 (Apple Git-146), so it's not a difference in git versions.

I tried to downgrade, but I'm unsure where to find the binaries.

@vixipop
Copy link

vixipop commented Apr 29, 2024

been facing this ; tried clean install ; and beta ; it didnt work help pls

@prma85
Copy link

prma85 commented Jun 11, 2024

been facing this ; tried clean install ; and beta ; it didnt work help pls

Same here. New install and nothing :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Relating to things affecting performance
Projects
None yet
Development

No branches or pull requests