[code suggestion] multiples of || into Array.includes

[ghost]

https://github.com/desktop/desktop/blob/master/app/src/models/app-menu.ts#L247-L252

export function itemMayHaveAccessKey(item: MenuItem): item is IMenuItem | ISubmenuItem | ICheckboxMenuItem | IRadioMenuItem {
  return item.type === 'menuItem' ||
    item.type === 'submenuItem' ||
    item.type === 'checkbox' ||
    item.type === 'radio'
}

maybe have it converted to:

['menuItem', 'submenuItem', 'checkbox', 'radio'].includes(item.type)

?

not sure if TS supports it though

[shiftkey]

According to the Typescript sandbox:

[ghost]

yeah, i tried tsc locally -- same result, but according to microsoft/TypeScript#2340 it should have been working since TS 2.1.5

how is array of strings not a direct descendent of Array 🤔

[shiftkey]

@noformnocontent Probably because we're not on ES7 yet, which seems to be a requirement.

[ghost]

yeah, switching to ES7 is probably too big of a change for this issue to be fixed