Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status popup while pushing shows current/current instead of current/maximum for size #16468

Open
Clonkex opened this issue Apr 6, 2023 · 3 comments

Comments

@Clonkex
Copy link

Clonkex commented Apr 6, 2023

The problem

When hovering the main fetch/push button in the top bar while pushing is in progress, a status popup appears. This popup shows the currently-uploading file, as well as the currently-completed number of files out of the total number files to be uploaded. It seems that it's also meant to show the currently-completed data size out of the total data size to be uploaded, however it always just shows the currently-completed data size out of the currently-completed data size (same value on both sides).

Release version

3.2.0 (x64)

Operating system

Windows 10 10.0.19045 Build 19045

Steps to reproduce the behavior

  1. Make some changes in a repo, especially involving large files
  2. Begin pushing those changes
  3. Hover the "push" button (while it says "Pushing to origin") and see that the data size numbers don't make sense

Log files

No response

Screenshots

image

Additional context

No response

@steveward
Copy link
Member

@Clonkex thanks for the issue. I tested this using Git LFS and was unable to reproduce the behavior:

Screenshot 2023-04-06 at 11 07 25 AM

I'll take a look and see if I can reproduce it with multiple files.

@steveward steveward added the more-info-needed The submitter needs to provide more information about the issue label Apr 6, 2023
@github-actions
Copy link

Thank you for your issue!
We haven’t gotten a response to our questions above. With only the information that is currently in the issue, we don’t have enough information to take action. We’re going to close this but don’t hesitate to reach out if you have or find the answers we need. If you answer our questions above, this issue will automatically reopen.

@Clonkex
Copy link
Author

Clonkex commented Apr 14, 2023

I can still replicate the issue.

image

It occurred to me that I think the repo is using Git LFS, which I presume is likely to have an impact on this issue.

@github-actions github-actions bot removed the more-info-needed The submitter needs to provide more information about the issue label Apr 14, 2023
@github-actions github-actions bot reopened this Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants