Add aria labeling to toolbar dropdown "caret" button #16839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
commented
Jun 5, 2023
| @@ -179,6 +179,7 @@ export class PushPullButton extends React.Component<IPushPullButtonProps> { | |||
| buttonClassName: 'push-pull-button', | |||
| style: ToolbarButtonStyle.Subtitle, | |||
| dropdownStyle: ToolbarDropdownStyle.MultiOption, | |||
| ariaLabel: 'Push, pull, fetch options', | |||
There was a problem hiding this comment.
Completely open to other words for a better way to communicate this. (This was auto pilot's suggestion :P)
Closed
sergiou87
approved these changes
Jun 6, 2023
| @@ -179,6 +179,7 @@ export class PushPullButton extends React.Component<IPushPullButtonProps> { | |||
| buttonClassName: 'push-pull-button', | |||
| style: ToolbarButtonStyle.Subtitle, | |||
| dropdownStyle: ToolbarDropdownStyle.MultiOption, | |||
| ariaLabel: 'Push, pull, fetch options', | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref: https://github.com/github/accessibility-audits/issues/4364
Description
Announces a description of the "pull, push, fetch" button dropdown to screen readers.
Screenshots
CleanShot.2023-06-05.at.13.17.34.mp4
Release notes
Notes: [Improved] The "pull, push, fetch" dropdown button has an aria-label for screen reader users.