Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Added] Add Zed Preview as an external editor option #17097

Merged
merged 4 commits into from Aug 10, 2023

Conversation

filiptronicek
Copy link
Contributor

Description

Recently, Zed introduced their Preview release channel along with a new app for its utilization. This PR contributes the Zed Preview editor to be used and opened from within GitHub Desktop.

Related issues

The regular flavor of the editor has been contributed in #16338. I have tried to keep the changelog entry & PR title similar.

Release notes

Notes: Add Zed Preview as an external editor option

@filiptronicek
Copy link
Contributor Author

cc @JosephTLyons because you authored the original PR for adding Zed 👋

@JosephTLyons
Copy link
Contributor

This is super cool! We use preview at Zed - stoked at the idea of opening it through Desktop!

@tsvetilian-ty
Copy link
Member

Thanks for the contribution 🥳 ! I can confirm it works. @filiptronicek could you add Zed to the list with supported editors in editor-integration.md?

Something like:

[Zed](https://zed.dev/) - both stable and Preview channel

@filiptronicek
Copy link
Contributor Author

Should be good now, @tsvetilian-ty

Copy link
Contributor

@tidy-dev tidy-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ Thank you for the contribution!

@tidy-dev tidy-dev merged commit 0179746 into desktop:development Aug 10, 2023
7 checks passed
@filiptronicek filiptronicek deleted the ft/zed-preview-editor branch August 10, 2023 12:39
Copy link

@mervy9327 mervy9327 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants