Enable context menu shortcut for file list items in a commit #17143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiou87
changed the title
tidy-dev
previously approved these changes
Jul 31, 2023
tidy-dev
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref. https://github.com/github/accessibility-audits/issues/4934
Description
As with other PRs to fix this kind of issue, this PR just removes the
onContextMenufrom the file item rowdivelement, and uses theList'sonRowContextMenuin order to make VoiceOver's context menu shortcut work in the file list of a commit.Release notes
Notes: [Fixed] Enable context menu keyboard shortcut for file lists