Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In high contrast mode all themes look the same and diff is colorless #17191

Open
hiiamboris opened this issue Aug 7, 2023 · 4 comments
Open
Labels
accessibility Issues related to accessibility improvements enhancement

Comments

@hiiamboris
Copy link

The problem

Impossible to read the diff without colors.

Release version

Version 3.2.7 (x64)

Operating system

W10

Steps to reproduce the behavior

Use this theme

Log files

No response

Screenshots


Additional context

No response

@tidy-dev
Copy link
Contributor

tidy-dev commented Aug 8, 2023

@hiiamboris Thank you for the report! We are currently underway with accessibility improvements. However, at this time, our focus with theming is to ensure that are base themes meet WCAG contrast standards and it will likely be some time before we look into how system theme impacts our software.

Is the theme you mention a custom theme applied to windows? The reference makes me think it is not what naturally occurs when you select high contrast theme on windows?

Do you mind sharing if you regularly use your system's high contrast settings?

@tidy-dev tidy-dev added the more-info-needed The submitter needs to provide more information about the issue label Aug 8, 2023
@hiiamboris
Copy link
Author

Is the theme you mention a custom theme applied to windows? The reference makes me think it is not what naturally occurs when you select high contrast theme on windows?

It's customized but not a hack of any kind. Here's the out of the box "High Contrast #1" theme:

Do you mind sharing if you regularly use your system's high contrast settings?

100.0% of the time.

@github-actions github-actions bot removed the more-info-needed The submitter needs to provide more information about the issue label Aug 8, 2023
@tidy-dev tidy-dev added enhancement accessibility Issues related to accessibility improvements labels Aug 8, 2023
@ahmad-elafify-pci
Copy link

ahmad-elafify-pci commented Nov 6, 2023

Workaround I found online: Disable the high contrast mode/them on specific applications

To do this, go to the properties of the .exe of your program, Then add --disable-features=ForcedColors at the end of the target field. Example: C:\Users\PC\AppData\Local\GitHubDesktop\GitHubDesktop.exe --disable-features=ForcedColors

@Marv51
Copy link

Marv51 commented Feb 8, 2024

Since this issues basically come down to "test and support" high-contrast themes, I thought I can add this high-contrast issue:

When I apply the theme "Abenddämmerung" (sorry for the German) translates to "Dusk" or "sunset".

grafik

I get zero contrast between the the selected and the unselected choice in some of the dialogs:
grafik

There is no perceptible difference when I click the two choices.

I do not use high contrast themes regularly, only when testing my own app for compatibility. But then I run it for a couple of hours at a time. (Highly recommended!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issues related to accessibility improvements enhancement
Projects
None yet
Development

No branches or pull requests

4 participants