"Undo commit" dialog: can't false warnings be transparently handled?

[aybe]

The feature request

Example:

• I commit .editorconfig
• in fact I didn't intend to do it now (lol)
• so I undo the change
• greeted by the following message which is incorrect

The actual message:

The reality:

No changes will ever be lost, file was committed in whole, there are no remaining changes that would be overwritten if undo-ing.

Proposed solution

Maybe the software could avoid showing these false warnings for such cases?

There could be an option to set this behavior.

If these messages are tied to accessibility, above option should be original behavior so as to not break accessibility experience.

Additional context

No response

[steveward]

@aybe thanks for the issue. Just to confirm -- were there uncommitted changes present in your repository, but they weren't for the .editorconfig file?

The modal shows if there are any uncommitted changes (you can see some context around this in #12341 (review)). We tend to prefer to warn when at all possible since there are quite a few scenarios at play here that can cause lost data or confusion, and is also why we provide the option to disable the dialog.

[aybe]

Just to confirm -- were there uncommitted changes present in your repository, but they weren't for the .editorconfig file?

Exactly, other changes but not for the file being undo-ed.

---

Ironically, I just realized that there is already the option to disable the behavior...
It's funny how people tend to ignore everything around when they see a warning!🤣

I checked it and tried, yes, it is dangerous; I modified .editorconfig then undo-ed previous commit and it gave no warning.
I'd rather have the warning as I happen to commit specific lines but eventually can make mistakes so usual undo is a safety net.

But if somehow there could be a 'smart' behavior that is between the actual ones, that would be much appreciated!

[tidy-dev]

Drive by comment. Restoring a stash does what I think is requested here and only warns if there are files with the same name in the stash and in the changes list so possibility to reuse logic.