Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in GitHub? #2983

Closed
danqing opened this issue Oct 7, 2017 · 5 comments
Closed

Open in GitHub? #2983

danqing opened this issue Oct 7, 2017 · 5 comments

Comments

@danqing
Copy link

danqing commented Oct 7, 2017

This must have been filed before but I can't find it anywhere. I think the app should have an "Open in GitHub" button that opens the current repo in browser. The old app has a button that opens the current PR, which is good too.

Thanks!

@agisilaos
Copy link
Member

Hey @danqing I think you already can do that? About your second question I'm not sure if that's in the works already. Maybe @shiftkey can give a bit more info on that.

screen shot 2017-10-08 at 14 51 29

@danqing
Copy link
Author

danqing commented Oct 8, 2017

Oh interesting. So here's another feature that's unfortunately hidden in the menu...

Now the request goes back to exposing more things in the UI :)

@agisilaos
Copy link
Member

Back to your second comment, Interactions with PR's is under development. Hm, I don't think that's the right way to do it because a core feature of the app is to be simple regarding the UI. And that's one of the reasons that makes this app special. At least for me.

@danqing
Copy link
Author

danqing commented Oct 8, 2017

Well, I agree that we don't want a cluttered UI, but I think we also don't want a menubar app, which it surely looks like now - almost all features other than committing and syncing master are hidden in the top navbar.

I understand that switching to Electron means starting from scratch and it's reasonable to build up features gradually. I hope it's not an intentional design decision that things should be hidden in the menus.

@niik
Copy link
Member

niik commented Oct 9, 2017

Looks like this was answered already so I'm gonna close it out!

@niik niik closed this as completed Oct 9, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jul 19, 2018
@desktop desktop unlocked this conversation Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants