Visual Studio Code Insiders is not recognised as en editor

[msathieu]

I recently updated to the insiders version of Visual Studio Code, but now Github Desktop says that there are no editors installed.

Version

GitHub Desktop version: [1.0.3]

OS version: [Windows 10]

Steps to Reproduce

1. [Install Desktop and VSCode insiders]
2. [Try to open a project in the editor]

Expected behavior: [Open the project in VSCode]

Actual behavior: [Gives an error about no editor]
Reproduces how often: [100%]

[shiftkey]

@msathieu not surprising - these are the registry keys we use to find the VSCode install (64-bit or 32-bit), and this is how we identify it's the right app.

If they differ only by these details, it should be easy to extend it. Are you interested in digging up those details and contributing a PR? I'm happy to guide you along the way.

[msathieu]

OK, I'll try @shiftkey . Should i try to detect it under ExternalEditor.VisualStudioCode or should i add something like ExternalEditor.VisualStudioCodeInsiders?

[lee-dohm]

@msathieu Could you supply steps to reproduce the errant behavior here now that #3012 is merged?

[msathieu]

Install Insiders and try to open a repo from Desktop. I don't know if the bug would be fixed when I reinstall desktop or not.

[shiftkey]

@msathieu if you look at the dev tools with verbose enabled, you'll see this message:

Command line interface for Visual Studio Code not found at 'C:\Program Files\Microsoft VS Code Insiders\bin\code.cmd'

This file is named code-insiders.cmd (probably to ensure it doesn't clash with an existing VSCode install), so the code needs to detect this as a fallback.

[msathieu]

@shiftkey Should I make a new case, something like ExternalEditor.VisualStudioCodeInsiders?

[shiftkey]

@msathieu maybe? I don't think we can have multiple enum values mapped to a single string (so we can separate the logic for ExternalEditor.VisualStudioCodeInsiders but make it appear in the UI as 'Visual Studio Code') so maybe we'll need to call it 'Visual Studio Code (Insiders)'.

[shiftkey]

This was resolved by #3441