Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oversized image rendering in commit area #4185

Closed
LiveG-Technologies opened this issue Mar 6, 2018 · 1 comment
Closed

Oversized image rendering in commit area #4185

LiveG-Technologies opened this issue Mar 6, 2018 · 1 comment

Comments

@LiveG-Technologies
Copy link

Description

When big images appear in the commits preview area, they end up covering a large portion of the screen. Luckily, the branch and fetch/push buttons are on top.

Version

  • GitHub Desktop: Version 1.1.0
  • Operating system: Microsoft Windows [Version 10.0.16299.248]
  • Windows 10 Pro, 2736x1824px screen resolution, Microsoft Surface Pro 4

Steps to Reproduce

  1. In a repository, create a big image.
  2. Don't commit the image, click on the image's file name on the left of the window.
  3. The result will be shown.

Expected Behavior

Images should be resized to an appropriate size (say, 100%) and fit into the area.

Actual Behavior

When big images appear in the commits preview area, they end up covering a large portion of the screen.

Logs

2018-03-06T12:43:42.735Z - info: [ui] [AppStore] loading 3 repositories from store
2018-03-06T12:43:42.741Z - info: [ui] [AppStore] found account: FREEproject-OSS (FREEproject Open Source Systems)
2018-03-06T12:43:44.170Z - info: [ui] launching: 1.1.0 (Windows 10.0.16299)
2018-03-06T12:43:44.170Z - info: [ui] execPath: 'C:\Users\NIXE\AppData\Local\GitHubDesktop\app-1.1.0\GitHubDesktop.exe'
2018-03-06T12:43:45.064Z - info: [ui] Executing installGlobalLFSFilter: git lfs install --skip-repo (took 1.331s)
2018-03-06T12:44:01.795Z - info: [ui] Stats reported.
2018-03-06T12:44:09.942Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Branding - FREEproject-OSS (has token)
2018-03-06T12:44:58.336Z - info: [ui] Executing push: git -c credential.helper= push origin master:master --progress (took 48.303s)
2018-03-06T12:45:01.165Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 2.823s)
2018-03-06T12:45:09.480Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 3.654s)
2018-03-06T12:46:33.028Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: freeproject-oss.github.io - FREEproject-OSS (has token)
2018-03-06T12:46:39.583Z - info: [ui] Executing push: git -c credential.helper= push origin master:master --progress (took 6.467s)
2018-03-06T12:46:41.227Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 1.547s)
2018-03-06T12:50:22.134Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 2.055s)

@niik
Copy link
Member

niik commented Mar 6, 2018

Hey @LiveG-Technologies, I'm pretty sure this is the same as #2480 so I'm going to close it out but please subscribe to that issue to follow along!

@niik niik closed this as completed Mar 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jul 18, 2018
@desktop desktop unlocked this conversation Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants