Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

History list shows only ~100 items, expecting to see more #4964

Closed
NiklasBr opened this issue Jun 19, 2018 · 2 comments
Closed

History list shows only ~100 items, expecting to see more #4964

NiklasBr opened this issue Jun 19, 2018 · 2 comments
Assignees
@shiftkey
Labels
bug Confirmed bugs or reports that are very likely to be bugs

Comments

@NiklasBr
Copy link
Contributor

Description

The history list is only showing the latest 100 items or so, previous versions of the app could scroll back to the initial commit.

Version

  • GitHub Desktop: 1.2.3
  • Operating system: macOS 10.12.6 (16G1408)

Steps to Reproduce

  1. Open the History pane.
  2. Scroll down.

Expected Behaviour

I expect earlier commits to show up in the list. I think they were loaded dynamically as scrolling happened before.

Actual Behavior

No older commits are showing.

Additional Information

n/a

Logs

2018-06-19.desktop.production.log
@shiftkey shiftkey added the investigation-needed Likely bugs, but haven't been reliably reproduced by a reviewer label Jun 19, 2018
@shiftkey
Copy link
Member

@NiklasBr thanks for the report!

I think they were loaded dynamically as scrolling happened before.

Yes, this should have been happening. Let me see if I can reproduce this, as it feels like a recent regression.

@shiftkey shiftkey self-assigned this Jun 19, 2018
@shiftkey shiftkey added bug Confirmed bugs or reports that are very likely to be bugs and removed investigation-needed Likely bugs, but haven't been reliably reproduced by a reviewer labels Jun 19, 2018
@shiftkey
Copy link
Member

Yep, I can reproduce this on 1.2.3 on macOS and Windows. Figuring out how this was introduced.

@shiftkey shiftkey mentioned this issue Jun 19, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 21, 2018
@desktop desktop unlocked this conversation Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiftkey shiftkey

Labels
bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NiklasBr @shiftkey