-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a File Explorer context menu entry to launch Desktop #5373
Comments
For reference, Git for Windows does this by adding registry entries at install time (if the user has enabled it). Here's the source, so you can see what changes need to be made: https://github.com/git-for-windows/build-extra/blob/master/installer/install.iss#L2079-L2112 I'd love to wrap my head around how much interest there is in this feature, as our installer doesn't support the ability to let users opt-in for features like this, so we'd need to have a different UX for enabling it. This is also a Windows-specific feature, although there might be similar ways to do this in other OSes that I haven't looked into yet. |
Thanks! So I understand this a bit better, is the concept to essentially:
Is that correct? |
Yes, exactly that. |
Adding that shortcut there is easy, but you need to add a command line argument to GH Desktop e.g. I want this too, I'd like to replace TortoiseGit with an app, that I can just open a repo folder. I don't care about adding repos inside Github Desktop, there is so many, that it's just clumsy. I just want to open each repo from the folder I browse in explorer. Here is the Registry editor snippet stolen from Open with VSCode for reference, once you have created the command line argument:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
(Edited) You can run it directly here: Example: |
How about we make an opt-out option that automatically gets added by the installer. We can make this into a cascading menu with an option to opt-out. I think that is what most Windows users would want. https://blog.sverrirs.com/2014/05/creating-cascading-menu-items-in.html |
Regarding an opt-out option, I disagree: I believe that the user should be able to choose at installation whether he wants the context menu entry, just like e.g. VSCode installer does: |
@darkred I see your point, opt-in is probably servicing the user more and the cascading menu would be cumbersome indeed. I don't agree with adding options to the installer. GitHub Desktop has a really nice one-click no-questions installer, I think it should be a high priority to keep it that way. It would be sane to add it as a setting in File->Options. The reason I suggested the cascading option is that it would be the easiest way to add this feature without changing anything in the core of the app. Another option is to add a cascading entry that can be de-cascaded or discarded : |
Okay, so here is a proof of concept for adding a temporary options menu with a choice to either keep the entry or to discard the entry. I haven't really seen such a pseudo-interactive context menu, but it does check a lot of usability boxes: For me personally: this is the closest I can get to a fully isolated solution (isolated from the app) that I can immediately start using myself. For the community: it might be easy to rework this and add it to GitHub Desktop, but I have no idea how to integrate this with the app itself. What the script doesIt adds the necessary actions as scripts in the |
Or rather than building nested context menus it can be made into a checkbox under the Advanced tab in the Options. This way you can have opt-in, opt-out, allow user to change their mind later, allow marking menu item as Extended (so it only shows up if Shift key is being held) based on user preference and make menu item follow interface languages changes, although I don't see a setting for that anywhere, I guess it's only available in English as of now. Thanks for the registry hack, heetbeet! Was about to make my own |
Requested in #15205. |
Requested in #17089:
|
Another example would be TortoiseGit. It gives you basically all git commands in the context menu |
Using GitHub Desktop 1.3.2 x64 in win 10.
Currently in order to add a repo to GitHub Desktop
you have to either use the dialogs: File|New Repository or File|Open Local Repository
or drag'n'drop a repo folder inside GitHub Desktop.
My suggestion is to add a File Explorer context menu entry, named e.g.
GitHub Desktop Here
.This would:
For reference, Git for Windows offers similar context menu entries: "Git GUI Here" and "Git Bash Here" and I find them very useful:
The text was updated successfully, but these errors were encountered: