Update login error message to reflect form input

[tierninho]

When using the login form (welcome flow or Preferences) we display an error message if the username/email/password is incorrect.

"Incorrect username or password."

However, the above error message is generic and only reflects the the username field. The error message should recognize when a user attempts to login with an email address.

• Do we make the error message dynamic or simply update the text? As the latter is easier, so I suggest we update the message to: "Incorrect username/email or password."

Code:

desktop/app/src/lib/stores/sign-in-store.ts

Line 357 in 0bf1cc9

error: new Error('Incorrect username or password.'),

1.4.2-beta0, mac

[Daniel-McCarthy]

I see a pull request is already currently open for this to update the message to include email in the error.

Though, if at a later time it's decided it would be preferable to go more dynamic, for deciding which to show it would likely be sufficient to check if the input text contains an @ since it is not a legal GitHub name character.

Just wanted to mention this as food for thought. 👍
It's great seeing the good first issue tag being used more.

[tierninho]

@tiagodenoronha thanks for the quick fix!!

@Daniel-McCarthy Yes, the dynamic route is a good option. I'll let the team weigh in first. Many thanks for the input and all the hard work!

[tiagodenoronha]

That is actually a nice solution. Check whether the input has an @ and present a different message per case!

[tiagodenoronha]

@tierninho Close if it's ok!