Potentially unclear during onboarding what version of Desktop I'm using

[tierninho]

TheAbout GitHub Desktop menu item is disabled when the user is onboarding. We should enable it so the user can easily see which build version they are using.

However, the top-level menu is not present on Windows until after onboarding. As such, a text based approach i/o a menu change seems more practical. Thoughts, opinions, etc...?

Mac/Darwin: About is under the GitHub Desktop menu
Windows/WIN: About is under the Help menu

Good place to start:

desktop/app/src/main-process/menu/build-default-menu.ts

Line 28 in 4460c48

if (__DARWIN__) {

Tip: in order not to blow away your current repos in Desktop, you can access the onboarding pages by changing this to 0:

[shiftkey]

@tierninho

Windows/WIN: About is under the Help menu

The menu is not visible when using the Welcome Wizard on Windows

Also, there are already ways to find the version installed without needing to launch the app:

[tierninho]

@shiftkey Yes, there are ways to find out, but the novice may not know how to inherently do that.

Also, I mentioned this, so perhaps it's an alternative if we decide to implement anything:

However, the top-level menu is not present on Windows until after onboarding. As such, a text based approach i/o a menu change seems more practical.

[shiftkey]

Is the issue just that the version isn't visible to the user when they start the welcome wizard?

I'm trying to wrap my head around the value here, because we could do something like embed the version on that first page if it's really important. This version also gets embedded in logs, so we have plenty of place to grab this info already:

2018-09-27T18:30:24.500Z - info: [ui] [AppStore] loading 5 repositories from store
2018-09-27T18:30:25.034Z - info: [ui] launching: 1.4.1 (Windows 10.0.17134)

[tierninho]

Is the issue just that the version isn't visible to the user when they start the welcome wizard?

yes, correct

if it's really important...

Don't think so, just an minor enhancement. If you feel the value doesn't outweigh the effort, feel free to close the issue or we can assign to the open contributors. I'm open either way.

[shiftkey]

I'll let @desktop/maintainers and @desktop/comrades sound off on this too

[j-f1]

How about a light gray “About GitHub Desktop” link tucked away in a corner of the welcome wizard?

[billygriffin]

This feels small enough to address in context of #5686 as we look at onboarding more holistically (linked it so it'd be captured there). Does that seem reasonable?

[tierninho]

Closing this issue for now in light of ⬆️