Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding buttons are backwards #5772

Closed
tierninho opened this issue Sep 27, 2018 · 2 comments
Closed

Onboarding buttons are backwards #5772

tierninho opened this issue Sep 27, 2018 · 2 comments

Comments

@tierninho
Copy link
Contributor

The Desktop onboarding process in the Welcome flow currently shows multiple forms, each with the primary action button (blue one) on the left, and secondary button on the right. This is opposite of the rest of the app, which has the primary action button on the right and secondary button on the left (unless it is a destructive action).

  1. Github.com sign-in
  2. Enterprise sign-in
  3. Git sign-in
  4. Stats agreement

screen shot 2018-09-27 at 1 47 03 pm

screen shot 2018-09-27 at 1 43 42 pm

screen shot 2018-09-27 at 1 43 29 pm

screen shot 2018-09-27 at 1 43 22 pm

Original convo around button order: #1311

Can a @desktop/maintainers confirm this change?
@billygriffin
Copy link
Contributor

We're looking at the entire onboarding experience in #5686 so just wanted to make sure this was linked in that issue.

@tierninho
Copy link
Contributor Author

Closing this issue for now in light of ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billygriffin @tierninho