Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lack of progress indicator on merge button #6120

Open
shiftkey opened this issue Nov 7, 2018 · 3 comments
Open

lack of progress indicator on merge button #6120

shiftkey opened this issue Nov 7, 2018 · 3 comments

Comments

@shiftkey
Copy link
Member

shiftkey commented Nov 7, 2018

Please describe the problem you think should be solved

After doing a bunch of testing for the upcoming 1.5 release, I've been missing an indicator that the merge is underway. For complex merges (where branches differ by 100s of commits) that take a while to complete, this means:

  • you click the button to start the merge (whether in the compare tab or the "Merge into current branch" dialog)
  • you wait an unclear amount of time while things are happening in the background
  • the merge completes or you need to resolve conflicts

[Optional] Do you have any potential solutions in mind?

I like our pattern when committing to show the indeterminate progress indicator:

spinner

Also, we should disable the merge button to prevent multiple merges.

@shiftkey shiftkey changed the title lack of merge progress indicator lack of progress indicator on merge button Nov 7, 2018
@shiftkey
Copy link
Member Author

shiftkey commented Nov 7, 2018

The new Merge Conflicts dialog could also be helped by this change:

@niik
Copy link
Member

niik commented Sep 16, 2020

For future reference the merge conflicts dialog now has progress indication, see #10458

@steveward
Copy link
Member

Requested in #11650.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants