Home/End keys do not work in diff view

[jessetan]

Description

It can be convenient to jump to the end of a long list of changed files using the End key. It can also be convenient to jump to the end of a long diff by pressing the End key.

The first one works, the second doesn't 😢

Version

• GitHub Desktop: 1.5.0
• Operating system: macOS 10.13.6

Steps to Reproduce

1. Open a repo and make changes to multiple files, so that the list does not fit in the window height
2. Click a file name
3. Press End and Home to jump to the bottom and top of the list
4. Click on a file that has a large diff that does not fit in the window height
5. Click on the diff to focus it
6. Press End and Home to attempt to jump to the button and top of the diff
7. Be slightly disappointed when nothing happens in 6.

Expected Behavior

The diff can be navigated using Home and End keys.

Actual Behavior

Diff window does not respond to Home and End keys (it does respond to PgUp and PgDn).
Changed files list only responds when the focused file is on screen. If it scrolls outside the visible area, keys no longer function.

[iAmWillShepherd]

Thanks for creating this issue, @jessetan

This is likely because all the engineers (4 of us) use MacBook Pros for development. As far as I know, there is no Home or End keys on our keyboards. This could be 100% false, two of our engineers are not based in America, so maybe their keyboards have it 🤔 .

In any case, I'm going to add the help wanted label to this for anyone in the community who is interested in tackling this.

[HZooly]

@iAmWillShepherd Aren't Cmd + Up/Down same than Home End key ? I'm not sure

[msftrncs]

@jessetan, CTRL-HOME and CTRL-END seem to work for me in the DIFF view. Both (CTRL or no CTRL) seem to work in the changed files list of a commit view. They only seem to work once while in the commit history list; in this case, the selection is removed from the item, the display moves accordingly and then nothing happens if you try HOME or END or CTRL-HOME or CTRL-END until another item is selected.

[jessetan]

Cmd+Up and Cmd+Down also work for me in diff view, but the native Home and End keys don't.

I also see what @msftrncs is reporting in the Changes file list: only if the focused item is visible on the screen the Home and End keys work, otherwise they do nothing. I've updated the report to include this, although it might be a separate issue.

[tierninho]

Looks like three parts of the History feature would benefit from this, as outlined in the pic.

Currently, Fn+Left/Right arrows kind of work on a Mac for Home & End, but it is far from perfect and functionality is inconsistent.

Ideally, cmd+up/down arrows seems like a better fit to be implement.

[AndreiMaga]

I wanna take a swing at this one.
So the expected behavior is :

• Press Home => Jump to start of the diff
• Press End => Jump to end of diff

Without messing with the current shortcuts.
As for the other history elements: Looks like sometimes home/end works (at least on windows), but only after you refocus.