Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lua and Fortran syntax highlighting. #6700

Closed
plastictortoise opened this issue Jan 23, 2019 · 4 comments
Closed

Add Lua and Fortran syntax highlighting. #6700

plastictortoise opened this issue Jan 23, 2019 · 4 comments
Labels
enhancement help wanted Issues marked as ideal for external contributors
Projects
Milestone

Comments

@plastictortoise
Copy link
Contributor

Add Lua and Fortran

  1. Open a Lua and Fortran file and find that there is no syntax highlighting.

I have wired up VB syntax highlighting, so I know how to do it and Lua and Fortran are included in codemirror.

I have opened up this discussion to make sure I can add it.

@plastictortoise
Copy link
Contributor Author

If discussion is started, I will

  1. Add the files to highlighter-tests
  2. Add the languages to the list in /docs/technical/syntax-highlighting.md
  3. Wireup logic in /app/src/highlighter/index.ts

I'm just checking that is everything.

@billygriffin
Copy link
Contributor

@simplebinary Thanks for the issue! Just so I'm understanding correctly, you're saying you'd like to add syntax highlighting in Desktop for Lua and Fortran, and that the capability exists in CodeMirror - and you're opening the issue to start a conversation and make sure we're 👍 on it before submitting a PR?

If so, I don't see any reason why we can't support this, but I'd love someone from @desktop/engineering to weigh in to be sure.

@plastictortoise
Copy link
Contributor Author

@billygriffin Exactly, I'm just making sure you're 👍 before submitting a PR. Ok, I'll wait for someone from @desktop/engineering to be sure.

@shiftkey shiftkey added enhancement help wanted Issues marked as ideal for external contributors labels Jan 24, 2019
@shiftkey
Copy link
Member

@simplebinary @billygriffin sounds good to me!

@shiftkey shiftkey added this to the 1.6.2 milestone Jan 24, 2019
@shiftkey shiftkey added this to Available in Community via automation Jan 24, 2019
@shiftkey shiftkey moved this from Available to In progress in Community Jan 24, 2019
Community automation moved this from In progress to Done Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Issues marked as ideal for external contributors
Projects
Development

No branches or pull requests

3 participants