Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set conflict resolution tool #68

Closed
joshaber opened this issue Jun 20, 2016 · 6 comments
Closed

Set conflict resolution tool #68

joshaber opened this issue Jun 20, 2016 · 6 comments

Comments

@joshaber
Copy link
Contributor

Let the user select a conflict resolution tool that we can open for them.

@joshaber joshaber added this to the ?: Merging milestone Jun 20, 2016
@joshaber joshaber removed this from the ?: Merging milestone Jul 15, 2016
@pmn pmn mentioned this issue Nov 1, 2016
@joshaber joshaber self-assigned this Jan 13, 2017
@joshaber
Copy link
Contributor Author

joshaber commented Jan 13, 2017

How do we imagine this working? A dropdown based on git mergetool --tool-help? Name and command text entry? @pmn @donokuda

@joshaber
Copy link
Contributor Author

Moving this to M3 to match up with "Open Conflict Resolution Tool" button.

@joshaber joshaber removed their assignment Feb 7, 2017
@joshaber joshaber modified the milestones: M4: This One Goes to Elevenses, M3: The Last One Was Not Enough Feb 10, 2017
@joshaber joshaber added the design-input-needed Issues that require design input from the core team before the work can be started label Apr 6, 2017
@joshaber
Copy link
Contributor Author

joshaber commented Apr 6, 2017

@donokuda @niik This needs some 🏩 👀

@joshaber
Copy link
Contributor Author

@niik and I talked this over and decided to punt it and #71 to 1.0 when we have time to think more about our conflict resolution story.

@niik niik added this to Backlog in Design review Jun 20, 2017
@joshaber joshaber removed this from the 1.0: The Last Milestone milestone Jun 27, 2017
@joshaber joshaber added this to the 1.1 milestone Sep 7, 2017
@joshaber joshaber mentioned this issue Sep 7, 2017
@joshaber joshaber self-assigned this Sep 20, 2017
@joshaber joshaber removed their assignment Sep 22, 2017
@joshaber joshaber modified the milestones: 1.1, 1.2 Oct 23, 2017
@nerdneha nerdneha modified the milestones: 1.2, 1.3+ Feb 7, 2018
@shiftkey shiftkey removed this from the 1.3.0 milestone Jul 11, 2018
@SurajGupta
Copy link

SurajGupta commented Aug 29, 2018

I'd like to make another pitch for an external diff tool. I'm looking at the current product roadmap and the upcoming releases seem to tackle some pretty niche problems. One of the most basic scenarios/needs of a version control system is determining what's changed before you commit. It's no offense to this product, but the existing diff-view is just mediocre. Often enough it's actually misleading because it over- or under-emphasizes the extent of the changes to a file. That's no surprise, it's a hard problem and other companies have been focused on this space for over a decade. It's gotten to point now where I don't even look at the diff in GitHub Desktop, I switch to Source Tree so I can quickly perform a UI driven External Diff. I think y'all are underestimating the impact an External Diff feature would have from Day 1 of release versus pretty much everything that's in the product roadmap right now.

@billygriffin billygriffin removed the design-input-needed Issues that require design input from the core team before the work can be started label Aug 29, 2018
@billygriffin
Copy link
Contributor

Thanks for the feedback @SurajGupta! We've been doing a bunch of work so far this year on the merge flow, and the logical conclusion of that is the question, "so you've made it easier to collaborate and merge work, but when there are conflicts Desktop still doesn't handle that well, now what?"

This is something we're actively looking at in #5400, so I'm going to close this issue in favor of that one. We completely agree that a better experience for when conflicts arise has the potential to significantly improve the flow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Design review
Future Work
Development

No branches or pull requests

5 participants