Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog and conflicts dialogs are too small on larger displays #6851

Open
simison opened this issue Feb 14, 2019 · 5 comments
Open

Changelog and conflicts dialogs are too small on larger displays #6851

simison opened this issue Feb 14, 2019 · 5 comments
Labels
design-input-needed Issues that require design input from the core team before the work can be started enhancement help wanted Issues marked as ideal for external contributors

Comments

@simison
Copy link

simison commented Feb 14, 2019

When working on bigger displays, you don't really expect to see scrollsbars too often.

Experience of reading/scrolling the changelog in this tiny modal within a big app within a big screen is a bit frustrating. Especially because two columns aren't very "screen like"; it's very print/paper-like paradigm. So you end up scrolling back and forth this tiny scrollable area.

image

(Green = my display area)

@outofambit
Copy link
Contributor

Hi @simison thank you for filing this issue! I agree we could make the changelog modal responsive so that it takes up more of the screen on larger window sizes, but is still reasonably sized on smaller screens. I'm going to mark this as an enhancement. We'll need to define our max and min sizes but once that is done it should be fairly straightforward to implement. Thanks again!

@outofambit outofambit added enhancement design-input-needed Issues that require design input from the core team before the work can be started help wanted Issues marked as ideal for external contributors labels Feb 14, 2019
@AlexEnchanter
Copy link

While on the topic of small windows

skarmbild 57

there also seems to be no way to see the full file path. Which make the decision harder to choose what version of the file to go with.

@billygriffin billygriffin changed the title Changelog modal is too small Changelog and conflicts dialogs are too small on larger displays Mar 18, 2019
@yuzawa-san
Copy link
Contributor

Regardless of responsiveness, it would be ideal if these paths were never truncated with the ... since it is impossible to tell what the files are from the front part of the path.

@agisilaos
Copy link
Member

@niik Can we mark this issue as accessibility issue as well? In addition to that, I would like to work on it but I will definitely need some guidance.

@steveward
Copy link
Member

In #15295 it was brought up that the merge conflict modal truncation makes it difficult to quickly reference file locations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-input-needed Issues that require design input from the core team before the work can be started enhancement help wanted Issues marked as ideal for external contributors
Projects
None yet
Development

No branches or pull requests

7 participants
@simison @steveward @outofambit @yuzawa-san @agisilaos @AlexEnchanter and others