Avatar doesn't update with other user logging on

[jsmith2021Brandeis]

Description

Version

• GitHub Desktop:
  Version 1.6.2

• Operating system:
  Microsoft Windows [Version 10.0.17134.590]

Steps to Reproduce

1. Sign into GitHub desktop with account A
2. `Sign in to GitHub desktop with account B-->

Expected Behavior

The profile picture of user B is displayed in the lower left corner

Actual Behavior

The profile picture of user A is displayed in the lower left corner

Additional Information

Logs

2019-02-28T04:48:19.977Z - info: [ui] [AppStore] loading 2 repositories from store
2019-02-28T04:48:19.978Z - info: [ui] [AppStore] found account: hedlesschkn (Tim Heebs)
2019-02-28T04:48:20.505Z - info: [ui] launching: 1.6.1 (Windows 10.0.17134)
2019-02-28T04:48:20.506Z - info: [ui] execPath: 'C:\Users\MakerLab\AppData\Local\GitHubDesktop\app-1.6.1\GitHubDesktop.exe'
2019-02-28T04:48:21.318Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Zumo-Automation - hedlesschkn (has token)
2019-02-28T04:48:26.635Z - info: [ui] Executing fetch: git -c credential.helper= fetch --progress --prune origin (took 5.312s)
2019-02-28T04:48:39.317Z - info: [ui] Stats reported.
2019-02-28T04:48:39.337Z - info: [ui] Opt in reported.
2019-02-28T04:48:42.187Z - info: [ui] [AppStore.withAuthenticatingUser] account found for repository: Zumo-Automation - hedlesschkn (has token)
2019-02-28T04:48:43.390Z - info: [ui] Executing pull: git -c credential.helper= pull --no-rebase --progress origin (took 1.164s)
2019-02-28T04:49:21.259Z - info: [main] opening in browser: https://github.com/BrandeisMakerLab/Zumo-Automation/pull/new/master
2019-02-28T04:50:16.572Z - info: [ui] [AppStore] removing account hedlesschkn (Tim Heebs) from store
2019-02-28T04:50:20.875Z - info: [ui] Background fetch for 2 repositories took 0.835sec
2019-02-28T04:50:27.589Z - info: [ui] [AppStore] adding account jsmith2021Brandeis (Jacob Smith) to store
2019-02-28T04:56:25.881Z - info: [ui] [AppStore] loading 2 repositories from store
2019-02-28T04:56:25.881Z - info: [ui] [AppStore] found account: jsmith2021Brandeis (Jacob Smith)
2019-02-28T04:56:26.171Z - info: [ui] launching: 1.6.2 (Windows 10.0.17134)
2019-02-28T04:56:26.172Z - info: [ui] execPath: 'C:\Users\MakerLab\AppData\Local\GitHubDesktop\app-1.6.2\GitHubDesktop.exe'
2019-02-28T04:56:31.516Z - info: [ui] [AppStore] removing account jsmith2021Brandeis (Jacob Smith) from store
2019-02-28T04:56:43.096Z - info: [ui] [AppStore] adding account jsmithTest (jsmithTest) to store
2019-02-28T04:58:27.144Z - info: [ui] Background fetch for 2 repositories took 1.213sec

[jsmith2021Brandeis]

Account A Sign in:

Account B Sign in:

Account A's profile image is still displayed

[shiftkey]

@jsmith2021Brandeis thanks for the report!

Expected Behavior

The profile picture of user B is displayed in the lower left corner

Actual Behavior

The profile picture of user A is displayed in the lower left corner

The avatar in the commit form is shown based on the details provided in your Git config for user.name and user.email, to show who will be associated with the next commit.

This can be set as part of the Welcome flow when you first launch the app, or changed at any time in the Options | Git menu.

We don't currently update your user.name and user.email when you sign into a different GitHub account, because the global config is shared between other Git tools and it might be confusing for it to just suddenly change.

[billygriffin]

Thanks so much for the report @jsmith2021Brandeis! I added a reference to this in #610 as we're looking at commit attribution there and the alignment between a user's Git setup and their GitHub account, and hopefully improving that experience. This is aligned closely enough that I want to examine this as part of whatever we do for that, so I'm going to close this issue. Thanks again for helping us understand how this impacts folks.