-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get more context around the code I'm looking at in a diff #7014
Comments
Hi @varkor, thanks for the idea! This has come up a few times but less frequently than we would’ve thought to be honest. Would you mind sharing a couple examples of scenarios where you would use this, and what problem it’s solving for you so we can understand it a bit better? Thanks! |
Dropping in to mention that I also recently got a feature request for this via Halp. |
I think the reason I don't run into this more often is because I mainly navigate code on GitHub, rather than through the app (and the commits I'm making are usually in a context I'm familiar with, so I don't need to unfold so frequently). However, when I've made a change to a part of a codebase I'm not so familiar with, and I'm looking back at a commit I've made in the past, having a little more context can be enough to jog my memory (especially details like enclosing function names, etc.). |
@varkor Makes total sense to me, thank you! I'm going to leave this here and remove I think this would be a nontrivial change based on discussions we've had in the past, so I want to understand more about whether other people are experiencing this pain and how. If anyone else has a similar pain point, I'd love it if you'd react to the original issue here and/or respond with how it impacts you. |
@billygriffin Same pain here. I would really like to be able to easily see a "full" split view with all the context (GitKraken for example has that mode available). I'm personally using the web interface, not the desktop. Thanks! |
Similar thing here. Working in a project I don't know, I usually scroll through the diff before I commit to make sure I understand all the changes I made and didn't do anything stupid. If I noticed I changed a line, but don't immediately remember why, I tend to want to look at the function name or at least some surrounding code, which would be a lot easier if I could expand for some context. |
yes, please, this really a pain in the A** |
Hi folks, just wanted to update you that we're working on this and our initial version is now on beta! You can download the beta here if you'd like to try it out: https://github.com/desktop/desktop#beta-channel Because we're only planning minor follow-up work on this, I'm going to close this issue. Please let us know your feedback from using it if you wouldn't mind. ❤️ |
I appreciate this very much! Thank you! |
thanks a lot |
|
At the moment, the context of (lines preceding and following) the diffs is fixed. It would be useful to allow the user to unfold lines around the diff, like in GitHub itself.
For example, this is how a change is currently displayed in GitHub Desktop:
![image](https://user-images.githubusercontent.com/3943692/53873026-6bd36980-3ff7-11e9-9831-f799171e5a01.png)
This is how it looks like in GitHub on the web (with an unfold button):
![image](https://user-images.githubusercontent.com/3943692/53873072-83aaed80-3ff7-11e9-8ad6-7b91e694a01a.png)
#1544 seems related, but I couldn't find this precise issue anywhere.
The text was updated successfully, but these errors were encountered: