Inconsistent behavior for Recent repo grouping

[tierninho]

When moving between repos, when the Recent segment is present, I noticed the current repo is sometimes in the list and sometimes not. The inconsistency could be by design, but wanted to reference it here.

❓Note: almost the same issue as: #7130 (review) which was fixed?

Reproduce:

• Prerequisite: Make sure Recent segment is present in repo list, plus a few more repos

Scenario 1)

• Select a repo not in the Recent list = it doesn't get added to the Recent list (by design?)

Scenario 2)

• Select a repo not in the Recent list = it doesn't get added to the Recent list. Select the same repo again = it is now added to the Recent list.

Scenario 3)

• Select a repo not in the Recent list = it doesn't get added to the Recent list. Select the same repo again = it is now added to the Recent list. By repeating this a few times, I managed to get the Recent list down to 4 repos and even 3 repos.

Looking at these, I believe the logic is "always added the repo last used, not currently used".

v1.7.0-beta1, mac

[billygriffin]

@tierninho The logic is indeed to use the last repos used that are not the current repo, with the idea being that the current repo is selected and therefore not as relevant for navigating amongst the repos you've used most recently (since you're already on it). When @outofambit and I discussed this though, we could see it going either way. It's tricky for me to tell from your examples whether given that logic, is there still a problem?

[tierninho]

Ok, I suspected it the logic was meant to be this way. I still suggest looking at scenario 2 and 3 as they may be bugs or at least not intended situations.

[outofambit]

this is a good catch @tierninho, thank you! i didn't consider this case in my logic