Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we only check one repo's stash size at a time from refreshRepository #7584

Open
outofambit opened this issue May 20, 2019 · 0 comments
Labels
epic:stashing Tracking label for work related to the stashing flow metrics measuring user behavior for better decisions performance Relating to things affecting performance

Comments

@outofambit
Copy link
Contributor

(from investigation by @niik)

While repositories are refreshed serially the actual metric update check is not awaited meaning that theoretically more than one stash check could run simultaneously.


(from me, @outofambit)

This

this.updateStashEntryCountMetric(repository)
is where the metric update check is run (and not await-ed).

The tradeoff here is that if we await that call, the results of _refreshRepository, we block other sequential operations that come afterwards until that check is finished. (_refreshRepository is await-ed in a few key places, like checkout, commit, and pull). However, since we limit ourselves to one metric update check per 24 hours, this will probably not result in a noticeable performance difference.

@outofambit outofambit added performance Relating to things affecting performance epic:stashing Tracking label for work related to the stashing flow labels May 20, 2019
@outofambit outofambit added this to the 1.7.0 milestone May 20, 2019
@nerdneha nerdneha added this to Needs Triage in 2.0.0 Release May 20, 2019
@nerdneha nerdneha moved this from Needs Triage to New Work in 2.0.0 Release May 20, 2019
@shiftkey shiftkey removed this from the 1.7.0 milestone May 21, 2019
@shiftkey shiftkey removed this from New Work in 2.0.0 Release May 21, 2019
@outofambit outofambit added the metrics measuring user behavior for better decisions label Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic:stashing Tracking label for work related to the stashing flow metrics measuring user behavior for better decisions performance Relating to things affecting performance
Projects
None yet
Development

No branches or pull requests

2 participants