Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stash menu item should not be enabled when a dialog is active #7689

Open
shiftkey opened this issue Jun 5, 2019 · 2 comments
Open

stash menu item should not be enabled when a dialog is active #7689

shiftkey opened this issue Jun 5, 2019 · 2 comments
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
Desktop Housekeeping

Comments

@shiftkey
Copy link
Member

shiftkey commented Jun 5, 2019

Description

A bit of polish to the new menu item for viewing the current stash

Version

  • GitHub Desktop: 2.0.0
  • Operating system: macOS 10.14.5

Steps to Reproduce

  1. Create a stash on the current branch
  2. View the stash
  3. Press Discard to show the confirmation dialog
  4. Open the View menu

Expected Behavior

Show/Hide stashed changes is disabled, like some other menu items under View

Actual Behavior

Show/Hide stashed changes is enabled, and can be switched while viewing a dialog leading to some confusion:
@shiftkey shiftkey added bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature labels Jun 5, 2019
@zerefwayne
Copy link

@shiftkey I would like to fix this. 👍

@shiftkey
Copy link
Member Author

shiftkey commented Jun 6, 2019

@zerefwayne this needs a better writeup before I attach the help wanted label, to help guide external contributions. But if you want to take a shot at it without that information, you're more than welcome! Let me know if you have any other questions about it.

@sergiou87 sergiou87 added this to Triage in Desktop Housekeeping via automation Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
Desktop Housekeeping
Triage
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shiftkey @zerefwayne