Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error for failure to resolve editor after it has been uninstalled #8386

Closed
kuychaco opened this issue Oct 2, 2019 · 1 comment
Closed

Error for failure to resolve editor after it has been uninstalled #8386

kuychaco opened this issue Oct 2, 2019 · 1 comment
Assignees
@kuychaco
Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
Desktop 2.2.2 Release

Comments

@kuychaco
Copy link
Contributor

kuychaco commented Oct 2, 2019 •
edited

Fullscreen_10_1_19__6_52_PM

Repro steps:

  1. Install Atom and another valid editor (like VS Code)
  2. Set Atom as your editor in Preferences
  3. Uninstall Atom (on Mac, you can simply move to trash)
  4. Reload GitHub Desktop

Expected: New editor (like VS Code) is set as editor. If in tutorial, the first step should be marked complete

Actual: Error and Desktop has not detected new editor. If in tutorial, the first step is not marked complete despite there being an installed editor

[Edit] Also note that this bug prevents people from opening their editor to resolve merge conflicts if they've uninstalled their selected editor:

GitHub_Desktop-dev
@kuychaco kuychaco mentioned this issue Oct 2, 2019
Merged
@niik niik mentioned this issue Oct 2, 2019
Closed
@outofambit outofambit added the bug Confirmed bugs or reports that are very likely to be bugs label Oct 2, 2019
@tierninho tierninho added the priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature label Oct 2, 2019
@kuychaco kuychaco added this to Backlog in Desktop 2.2.2 Release via automation Oct 3, 2019
@kuychaco kuychaco moved this from Backlog to In progress Issues in Desktop 2.2.2 Release Oct 3, 2019
@kuychaco kuychaco self-assigned this Oct 3, 2019
@kuychaco kuychaco mentioned this issue Oct 3, 2019
Closed
@kuychaco
Copy link
Contributor Author

Fixed in #8388

Desktop 2.2.2 Release automation moved this from In progress Issues to Done! Oct 17, 2019
@ghost ghost mentioned this issue Nov 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuychaco kuychaco

Labels
bug Confirmed bugs or reports that are very likely to be bugs priority-3 Bugs that affect small number of users and/or relatively cosmetic in nature
Projects
No open projects
Desktop 2.2.2 Release
  
Done!
Milestone
No milestone
Development

No branches or pull requests
3 participants
@outofambit @kuychaco @tierninho